Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for **kwargs as the final argument for public methods as needed #20

Closed
dorono opened this issue May 13, 2019 · 1 comment
Closed

Comments

@dorono
Copy link
Contributor

dorono commented May 13, 2019

This is simply to allow for optional settings in our methods in the future.

By adding **kwargs as the final argument in any of these functions, we can reserve that space for any optional properties we could add, without having to worry about the order of any existing properties.

So the task here to to move all optional arguments to go under the **kwargs object, and then pull those **kwargs properties out into the body of the method.

@hieumt2
Copy link
Contributor

hieumt2 commented May 16, 2019

@dorono @sambarnes please review PR #22 updated code for this issue

@dorono dorono closed this as completed May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants