Client overrides #22
Client overrides #22
Conversation
|
@hieumt2 Looks great! I was going to rebase it against master (which was updated 4 days ago) and merge it myself, but I was thinking I would check with you just in case there is a reason you didn't want to rebase (can't imagine what that would be)? But anyhow, we are good to go on this PR! |
There was a problem hiding this comment.
@hieumt2 Hello again, sorry to take back my approval, but it looks like there may be some issues incorporating @sambarnes's changes (he added Anchors and Receipts clients) in PR #21, which is now part of master, and it is likely that there will be issues (I am still getting set up w/unit testing in this repo so I can't tell you precisely where the problems will be). I believe we should confirm that all of the tests are passing. I will look into it myself, but I just wanted to make sure that this didn't get merged until all of the tests are passing.
|
@dorono I have rebased from master and update for anchors and receipt clients |
No description provided.