Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to hitman module #2338

Closed
wants to merge 1 commit into from
Closed

Add new option to hitman module #2338

wants to merge 1 commit into from

Conversation

AMD-NICK
Copy link
Contributor

My knowledge of English isn't good enough to describe the need for this change

@FPtje
Copy link
Owner

FPtje commented Feb 24, 2016

I'd rather you'd have that config option prevent the setting of the DarkRPVar. Now clients still have the information.

@FPtje
Copy link
Owner

FPtje commented Feb 24, 2016

I looked into it a bit. The problem is that clients need the knowledge about whether a hitman has a hit for other reasons. One of them is when you press E on a hitman. When the hitman has a hit, you get a message that you cannot request a hit.

So, players can still see whether the hitman has a hit, even when the client isn't specifically sent that variable. The option has no use and would just disable the drawing of that one text. People would use it to "hide" hit information, which it won't do.

The PR doesn't do what one would expect it to do.

@FPtje FPtje closed this Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants