Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRML-152 Fix flaky LS annotation retrieval #70

Merged
merged 1 commit into from
Jun 7, 2024
Merged

FRML-152 Fix flaky LS annotation retrieval #70

merged 1 commit into from
Jun 7, 2024

Conversation

Eve-ning
Copy link
Collaborator

@Eve-ning Eve-ning commented Jun 6, 2024

Major Changes

The current method of task retrieval:

filter = Filters.create(
    Filters.AND,
    [
        Filters.item(
            # The GS path is in the image column, so we can just filter on that
            Column.data("image"),
            Operator.CONTAINS,
            Type.String,
            Path(file_name).as_posix(),
        )
    ],
)

is a big code smell

We improved it by making it more explicit (less blackboxy) by just using simple syntax for filtering
This can impact performance, but I don't think it'll be significant.

@Eve-ning Eve-ning merged commit f09d452 into 0.1.1 Jun 7, 2024
3 checks passed
@Eve-ning Eve-ning deleted the frml-152 branch June 7, 2024 07:20
@Eve-ning Eve-ning mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant