send the camera centric positions of where we think the nodes are #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravzilla
reviewed
Apr 12, 2023
| @@ -1035,9 +1035,6 @@ private void updateTeleopDrivingTarget(boolean recalculateGridPosition) { | |||
| } else { | |||
| // We're on the opposite side as our alliance | |||
| // Try to go to the pickup position | |||
| var predictedPoseForPickup = robotTracker.getLatestPose().getTranslation().plus( | |||
| robotTracker.getVelocity().times(0)); | |||
|
|
|||
ravzilla
reviewed
Apr 12, 2023
| yScoringOffsets | ||
| .get(isRedAlliance ? AllianceSide.RED : AllianceSide.BLUE) | ||
| .get(i) | ||
| .get(selectedPosition.getScoringDirection()); |
There was a problem hiding this comment.
could you make me a picture of the field with the axes directions on the origin? I know you have told me multiple times but i keep forgetting
ravzilla
reviewed
Apr 12, 2023
| } | ||
|
|
||
| return redYs; | ||
| } |
There was a problem hiding this comment.
whats the deal with this change? a refactor?
There was a problem hiding this comment.
That's the method we now call to get all the y-cords of the scoring positions so we can show them
There was a problem hiding this comment.
One of the methods this calls was unused so it wasn't updated to take the position offsets into account
ravzilla
reviewed
Apr 12, 2023
| var point = transformToCameraSpace(nodeLinePoints.get(i)); | ||
| nodeLinePointsToSend[i * 3] = point.getX(); | ||
| nodeLinePointsToSend[i * 3 + 1] = point.getY(); | ||
| nodeLinePointsToSend[i * 3 + 2] = point.getZ(); |
There was a problem hiding this comment.
can we not make a 2d array and flatten it? this code is fine, but ugly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.