Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better JSDoc tags #86

Merged
merged 1 commit into from
May 12, 2020
Merged

Better JSDoc tags #86

merged 1 commit into from
May 12, 2020

Conversation

cjdenio
Copy link
Contributor

@cjdenio cjdenio commented Feb 12, 2020

This magic PR fixes some errors that occurred whilst generating documentation. Mostly, migrated to @callback for callbacks and added return types.

@cjdenio cjdenio mentioned this pull request Feb 12, 2020
Open
@ErikBoesen
Copy link
Member

@AndrewLester

AndrewLester
AndrewLester approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@AndrewLester AndrewLester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@ErikBoesen ErikBoesen merged commit 8045847 into FRCDashboard:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikBoesen ErikBoesen ErikBoesen approved these changes

@AndrewLester AndrewLester AndrewLester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cjdenio @ErikBoesen @AndrewLester