Made self-deafens unable to @everyone in modlogs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-sourceress
previously requested changes
Dec 2, 2017
|
After discussion, we're just gonna make modlogging one huge function that handles everything automatically |
Decorator for moderation commands
…o in a better order (testing later)
tweirtx
dismissed
open-sourceress’s stale review
Cleaning applied to all commands by making modlogging a callable function
open-sourceress
previously approved these changes
Dec 7, 2017
LeoPiGuy
previously requested changes
Dec 7, 2017
There was a problem hiding this comment.
Alright not sure if this is just OCD talking, an actual problem, or nothing but I did notice a slight inconsistency with how you call modlogger(). Sometimes it is await self.modlogger(ctx=ctx, action="banned", target=user_mentions, reason=reason) and sometimes it is await self.modlogger(ctx, "unbanned", user_mentions, reason) If it is in fact nothing worth changing then just let me know and ill change my review. Otherwise, looks great!
open-sourceress
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.