Add multiple placement options for multinode uniconfig deployment #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jozefiel
commented
Jan 21, 2022
Jozefiel
commented
- change default single uc deployment from node.id to node.role
- add role, label, hostname options to generte_uc_compose.sh
- use x-common-settings in uc composefile
marosmars
reviewed
Jan 24, 2022
generate_uc_compose.sh
Outdated
| fi | ||
|
|
||
| if [[ -z $__SERVICE_NAME_DEFINED ]]; then | ||
| echo -e "${ERROR}Service name not defined. See help !!!" |
| x-placement: &placement | ||
| placement: | ||
| constraints: | ||
| - node.role == manager |
There was a problem hiding this comment.
should uniconfig be on manager node ?
There was a problem hiding this comment.
Default settings are for single-node deployment and all services are running on a master node.
This parameter is replaced during generation compose files by selected placement type.
generate_uc_compose.sh
Outdated
| echo -e "${SWARM_STATUS} Composefiles was not generated" | ||
| exit 1 | ||
| fi | ||
| echo -e "${SWARM_STATUS} Composefiles was force-generated with wrong placement settings" |
- change default single uc deployment from node.id to node.role - add role, label, hostname options to generte_uc_compose.sh - use x-common-settings in uc composefile
Jozefiel
force-pushed
the
uc_deployment_placement
branch
from
4e1be73
to
2ed5915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.