refactor : header, heading, 스크린리더 수정 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
숨김처리 텍스트 수정 Co-authored-by: jypark38 <jypark38@users.noreply.github.com> Co-authored-by: bo�gyeong.lee <ebokyung@users.noreply.github.com>
…l-19-EggplantMarket into feature/accessibility
ebokyung
reviewed
Jun 26, 2023
html/chat_list.html
Outdated
Comment on lines
24
to
25
| <a href="./chat_room.html" class="user-chat-content new-chat"> | ||
| <span class="a11y-hidden"></span> |
html/post_upload.html
Outdated
| <button id="upload-btn" class="size-ms btn-save" tabindex="0" disabled>업로드<span class="a11y-hidden">버튼</span></button> | ||
| <h1 class="a11y-hidden">게시물 업로드</h1> | ||
| <button id="upload-btn" class="size-ms btn-save" disabled>업로드<span class="a11y-hidden">하기</span></button> | ||
| <button class="btn-back"><img src="../assets/icon/icon-arrow-left.svg" alt="뒤로가기 버튼"></button> |
js/following.js
Outdated
Comment on lines
5
to
36
| const followers = document.querySelector('.follow-list'); | ||
| let reqCnt = 0; | ||
|
|
||
|
|
||
| // 1. 내가 내 팔로워 목록을 보는지, 내가 다른 사용자 팔로워 목록을 보는지 | ||
| const viewMyFollowerList = accountname === myAccountname ? true : false; | ||
|
|
||
|
|
||
| // 무한 스크롤 | ||
| window.addEventListener("scroll", async () => { | ||
| if (getScrollTop() >= getDocumentHeight() - window.innerHeight) { | ||
| console.log('바닥이당! 데이터 불러올게 기다려!') | ||
| throttle(makeList(await getFollowingList()), 1000) | ||
| if (viewMyFollowerList) { | ||
| throttle(makeMyFollowerList(await getFollowerList()), 1000) | ||
| } else { | ||
| throttle(makeUserFollowerList(await getFollowerList()), 1000) | ||
| } | ||
| }; | ||
| }) | ||
|
|
||
| // 버튼 이벤트 | ||
| followings.addEventListener('click', async (e) => { | ||
| if (e.target.classList.contains('btn-follow')) { | ||
| // 클릭한 요소의 사용자계정 | ||
| const clickedAccount = e.target.closest('li').querySelector('a').href.split('?accountName=')[1]; | ||
| async function run() { | ||
| const data = await getFollowerList(); | ||
| if (viewMyFollowerList) makeMyFollowerList(data); | ||
| else makeUserFollowerList(data); | ||
| }; | ||
|
|
||
| if (e.target.classList.contains('opposite')) { | ||
| // 언팔로우 기능 | ||
| await deleteFollow(clickedAccount); | ||
| run() | ||
|
|
||
| e.target.classList.remove('opposite'); | ||
| e.target.innerHTML = `팔로우<span class="a11y-hidden">하기 버튼</span>`; | ||
| } else { | ||
|
|
||
| // event | ||
| if (viewMyFollowerList) { | ||
| // (팔로우(하기) 버튼만 가능, 팔로워를 삭제하는 버튼은 있지만 기능은 없음 disabled 처리) |
js/home.js
Outdated
| } | ||
| if (item.image) { | ||
| liNode.querySelector('.post-edit a').insertAdjacentHTML('beforeend', `<div class="img-cover"><img class="post-img" src="${checkImageUrl(item.image,'post')}" alt="게시물 사진"></img></div>`) | ||
| liNode.querySelector('.post-edit a').insertAdjacentHTML('beforeend', `<div class="img-cover"><img class="post-img" src="${item.image}" alt=""></img></div>`) |
js/home_search.js
Outdated
| <a class="profile-img img-cover" href="./profile_info.html?accountName=${userData[i].accountname}"> | ||
| <img src="${checkImageUrl(userData[i].image,'profile')}" alt="프로필사진"> | ||
| <span class="a11y-hidden">${userData[i].username}의 프로필 보기</span> | ||
| <img src="${userData[i].image}" alt=""> |
js/postDetail.js
Outdated
| </div>`) | ||
| postInfoSec.querySelector('.btn-like').addEventListener('click',handleLike) | ||
| } | ||
|
|
||
| // 더보기 버튼 | ||
| const btnOption = document.createElement('button'); | ||
| btnOption.setAttribute('class', 'btn-option'); | ||
| btnOption.setAttribute('tabindex', '0'); | ||
| btnOption.innerHTML = `<img src="../assets/icon/icon-more-vertical.svg" alt="더보기 버튼">`; | ||
| btnOption.innerHTML = `<span class="a11y-hidden">게시물 옵션</span><img src="../assets/icon/icon-more-vertical.svg" alt="">`; |
js/postDetail.js
Outdated
| <p class="comment-text">${i.content}</p> | ||
| <button class="btn-more" tabindex="2" data-commentId=${i.id}><img src="../assets/icon/icon-more-vertical.svg" alt="더보기 버튼"></button>`; | ||
| <h3 class="comment-text">${i.content}</h3> | ||
| <button class="btn-more" data-commentId=${i.id}><span class="a11y-hidden">댓글 옵션</span><img src="../assets/icon/icon-more-vertical.svg" alt=""></button>`; |
js/profile_info.js
Outdated
| productName.insertAdjacentText('beforeend',`${item.itemName}`) | ||
|
|
||
| const productImg = document.createElement('img') | ||
| productImg.className='product-img' | ||
| productImg.setAttribute('src',`${checkImageUrl(item.itemImage,'post')}`) | ||
| productImg.setAttribute('alt','상품 이미지') | ||
| const itemSrc = item.itemImage.includes("https://api.mandarin.weniv.co.kr",) ? item.itemImage : "https://api.mandarin.weniv.co.kr/1687488082591.png" |
js/profile_info.js
Outdated
|
|
||
| const userImgImg = document.createElement('img'); | ||
| userImgImg.src = checkImageUrl(item.author.image,'profile'); | ||
| userImgImg.alt = '프로필사진'; | ||
| userImgImg.src = item.author.image; |
js/profile_info.js
Outdated
| @@ -253,7 +248,7 @@ function updatePost(post_data) { | |||
| const btnOption = document.createElement('button'); | |||
| btnOption.className = 'btn-option'; | |||
| btnOption.innerHTML = ` | |||
| <img src="../assets/icon/icon-more-vertical.svg" alt="더보기 버튼"> | |||
| <span class="a11y-hidden">게시물 옵션</span><img src="../assets/icon/icon-more-vertical.svg" alt=""> | |||
|
고생하셨습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : #72
전달 사항
개발 내용
추후 작업
참고 이미지