route redistribution in EIGRPD not work

[Churrofighter]

tested on master commit 33dfcd7

When redistribution for PROTOCOL(BGP, ISIS, rip,...) configure in EIGRP, EIGRP requests PROTOCOL routes from Zebra and then Zebra sends the routes. At this moment a ZEBRA_REDISTRIBUTE_ROUTE_ADD message receives from zebra and EIGRP handles this message in the eigrp_zebra_read_route function in the eigrp_zebra.c file.

because this function didn't compliment completely, these routes don't add and don't send for peers.

[Jafaral]

@Churrofighter can you provide more information? configs, environment, etc? see bug report template plz.

[Churrofighter]

@Churrofighter can you provide more information? configs, environment, etc? see bug report template plz.

Sure, how can i get eigrp debug logs?

[ak503]

looks like it's not implemented?

frr/eigrpd/eigrp_zebra.c

Lines 105 to 149 in 1f98f42

	static zclient_handler *const eigrp_handlers[] = {
	[ZEBRA_ROUTER_ID_UPDATE] = eigrp_router_id_update_zebra,
	[ZEBRA_INTERFACE_ADDRESS_ADD] = eigrp_interface_address_add,
	[ZEBRA_INTERFACE_ADDRESS_DELETE] = eigrp_interface_address_delete,
	[ZEBRA_REDISTRIBUTE_ROUTE_ADD] = eigrp_zebra_read_route,
	[ZEBRA_REDISTRIBUTE_ROUTE_DEL] = eigrp_zebra_read_route,
	[ZEBRA_ROUTE_NOTIFY_OWNER] = eigrp_zebra_route_notify_owner,
	};
	void eigrp_zebra_init(void)
	{
	struct zclient_options opt = {.receive_notify = false};
	zclient = zclient_new(master, &opt, eigrp_handlers,
	array_size(eigrp_handlers));
	zclient_init(zclient, ZEBRA_ROUTE_EIGRP, 0, &eigrpd_privs);
	zclient->zebra_connected = eigrp_zebra_connected;
	}
	/* Zebra route add and delete treatment. */
	static int eigrp_zebra_read_route(ZAPI_CALLBACK_ARGS)
	{
	struct zapi_route api;
	struct eigrp *eigrp;
	if (zapi_route_decode(zclient->ibuf, &api) < 0)
	return -1;
	if (IPV4_NET127(ntohl(api.prefix.u.prefix4.s_addr)))
	return 0;
	eigrp = eigrp_lookup(vrf_id);
	if (eigrp == NULL)
	return 0;
	if (cmd == ZEBRA_REDISTRIBUTE_ROUTE_ADD) {
	} else /* if (cmd == ZEBRA_REDISTRIBUTE_ROUTE_DEL) */
	{
	}
	return 0;
	}

[github-actions]

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

[frrbot]

This issue will be automatically closed in the specified period unless there is further activity.

[ak503]

it still doesn't work

[frrbot]

This issue will no longer be automatically closed.

[github-actions]

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

[frrbot]

This issue will be automatically closed in the specified period unless there is further activity.

[ak503]

up

[frrbot]

This issue will no longer be automatically closed.