Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP Prefix-SID unknown TLV support is broken #5752

Open
2 tasks
slankdev opened this issue Feb 4, 2020 · 0 comments
Open
2 tasks

BGP Prefix-SID unknown TLV support is broken #5752

slankdev opened this issue Feb 4, 2020 · 0 comments

Comments

@slankdev
Copy link
Contributor

slankdev commented Feb 4, 2020

https://tools.ietf.org/html/draft-ietf-idr-bgp-prefix-sid-27#section-3

For future extensibility, unknown TLVs MUST be ignored and propagated unmodified.

In the above draft defining the specification of Prefix-SID, draft says that unknown TLVs MUST be ignore and propagated. but current implementation doesn't achieve it.

frr/bgpd/bgp_attr.c

Lines 2276 to 2277 in f36c5df

else if (type == BGP_PREFIX_SID_SRV6_L3_SERVICE
|| type == BGP_PREFIX_SID_SRV6_L2_SERVICE) {

I sent the PR around that but that didn't fix the Prefix-SID problem completely, Current implementation is only ignoring partially, it doesn't propagate unknown TLV to another peer. My previous PR is here. #5278

And essential of this topi is no-test status cause this problem. Following task make bgpd's Prefix-SID implementation robust and better. I'll work for that. wait soon.

  • bgpd: suppor unknwon TLV of Prefix-SID
  • topotestt: add test for unknwon TLV of Prefix-SID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants