Reverse order sorted for display static routes

[ak503]

Hello!
If we have in config file some static routes:

ip route 1 ...
ip route 2 ...

then after starting staticd daemon every route will be added to head and in display we see:

ip route 2 ...
ip route 1 ...

May be need use static_path_list_add_tail instead static_path_list_add_head?

frr/staticd/static_routes.c

Line 236 in 10ddcc3

static_path_list_add_head(&(si->path_list), pn);

[idryzhov]

Isn't this a duplicate of #8746? Please, keep only one of those two.

Anyway, the correct approach for fixing this issue is to output staticd config using NB layer and implement cli_cmp callback for sorting.

[ak503]

Isn't this a duplicate of #8746?

No, this is a separate issues.

[idryzhov]

Could you elaborate, please, on how are they separate? They are both about the sorting of static routes in the configuration and FRR just doesn't sort the routes currently.

[ak503]

in #8746 FRR tries to sort by gateway but only if gateway is IP.
If gateway set as ifname, it s not sorting and displayed reverse list everytime after vtysh -c write and restart staticd. But may be it is a common ploblem.

ip route 1.1.1.1/32 lo1
ip route 1.1.1.1/32 lo2
ip route 2.2.2.2/32 3.3.3.2
ip route 2.2.2.2/32 3.3.3.1

after write and restart:

ip route 1.1.1.1/32 lo2
ip route 1.1.1.1/32 lo1
ip route 2.2.2.2/32 3.3.3.2
ip route 2.2.2.2/32 3.3.3.1

after write and restart again:

ip route 1.1.1.1/32 lo1
ip route 1.1.1.1/32 lo2
ip route 2.2.2.2/32 3.3.3.2
ip route 2.2.2.2/32 3.3.3.1

[idryzhov]

Thanks, now I see the difference. It tries to sort the routes when the nexthop is an IP address but does it incorrectly. And it doesn't even try to sort them when the nexthop is an interface.

Anyway, both problems should be solved using the NB layer (implementing cli_show and cli_cmp functions for nexthops), so I'd combine them into a single issue.

[qlyoung]

Please merge this problem description into #8746, since the functional impact is the same (none).