feat(utils): better typings for event targets

FRSOURCE · Mar 14, 2021 · 0ee1fdc · 0ee1fdc
1 parent ddc5f52
commit 0ee1fdc
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/packages/utils/src/events.ts b/packages/utils/src/events.ts
@@ -12,23 +12,23 @@ export type CustomEventListener<E extends keyof EventDetailMap = keyof EventDeta
 // TODO: add possibility to pass event/target array?
 
 export const on: {
-  <E extends keyof EventDetailMap>(target: Element, event: E, handler: CustomEventListener<E>, options?: boolean | AddEventListenerOptions): void;
-  (target: Element, event: string, handler: EventListener, options?: boolean | AddEventListenerOptions): void;
-} = (target: Element, event: string, handler: EventListener | CustomEventListener, options?: boolean | AddEventListenerOptions) => {
+  <E extends keyof EventDetailMap>(target: EventTarget, event: E, handler: CustomEventListener<E>, options?: boolean | AddEventListenerOptions): void;
+  (target: EventTarget, event: string, handler: EventListener, options?: boolean | AddEventListenerOptions): void;
+} = (target: EventTarget, event: string, handler: EventListener | CustomEventListener, options?: boolean | AddEventListenerOptions) => {
   target.addEventListener(event, handler as EventListener, options);
 }
 
 export const off: {
-  <E extends keyof EventDetailMap>(target: Element, event: E, handler: CustomEventListener<E>): void;
-  (target: Element, event: string, handler: EventListener): void;
-} = (target: Element, event: string, handler: EventListener | CustomEventListener) => {
+  <E extends keyof EventDetailMap>(target: EventTarget, event: E, handler: CustomEventListener<E>): void;
+  (target: EventTarget, event: string, handler: EventListener): void;
+} = (target: EventTarget, event: string, handler: EventListener | CustomEventListener) => {
   target.removeEventListener(event, handler as EventListener);
 }
 
 export const dispatch: {
-  <E extends keyof EventDetailMap, P extends EventDetailMap[E]>(target: Element, event: E, ...[payload, options]: (P extends undefined ? [undefined?, EventInit?] : never)): boolean;
-  <E extends keyof EventDetailMap>(target: Element, event: E, payload: EventDetailMap[E], options?: EventInit): boolean;
+  <E extends keyof EventDetailMap, P extends EventDetailMap[E]>(target: EventTarget, event: E, ...[payload, options]: (P extends undefined ? [undefined?, EventInit?] : never)): boolean;
+  <E extends keyof EventDetailMap>(target: EventTarget, event: E, payload: EventDetailMap[E], options?: EventInit): boolean;
 } = <E extends keyof EventDetailMap>(
-  target: Element, event: E, payload?: EventDetailMap[E], options?: EventInit
+  target: EventTarget, event: E, payload?: EventDetailMap[E], options?: EventInit
 ) =>
   target.dispatchEvent(new CustomEvent(event, Object.assign({ detail: payload }, options)));