Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using lap times instead of laps #263

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Using lap times instead of laps #263

merged 3 commits into from
Feb 17, 2021

Conversation

wouter-heerwegh
Copy link
Member

@wouter-heerwegh wouter-heerwegh commented Feb 9, 2021 •
edited
Loading

Still needs an updated reference to fs_msgs when pull request is merged

SijmenHuizenga
SijmenHuizenga reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@SijmenHuizenga SijmenHuizenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The fs_msgs pr has been merged.

Can you just confirm that the commit about making the startfinishline symatrical is indeed intended to be part of this pr? If so we can merge it 🚀

@wouter-heerwegh
Copy link
Member Author

Ah yes, it's a fix because i messed it up somewhere in pr #255. I would like to add it sooner rather than later. It hurts to see it being asymmetrical.

@SijmenHuizenga SijmenHuizenga merged commit 97dcf48 into FS-Driverless:master Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SijmenHuizenga SijmenHuizenga SijmenHuizenga left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wouter-heerwegh @SijmenHuizenga