Fix starting offset of 2m in X #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouter-heerwegh
force-pushed
the
master
branch
from
be29e9b
to
77c3640
Compare
|
Removed my temporary fix for Eigen, since it is back up |
|
Added last commit to be more clear, see issue #270 |
wouter-heerwegh
force-pushed
the
master
branch
from
f30eff3
to
a31bdb8
Compare
davidoort
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the offset of 2m in the X direction. Seems like the FVector is initiated with 0's instead of NaN's. Should be NaN's when built in Release of shipping mode, but since the functionality of the if statement is not used, I just commented it out.
This fixes following issues #144 and #256
I wanted to also build a new release but kept getting errors about "no member named 'GetCachedContainer' in 'FCachedPropertyPath'", so I wanted to update Airsim, but it seems like I can't download eigen. Seems like there is a problem with gitlab, since the repo of eigen just throws a 404.
@SijmenHuizenga Maybe it would be nice to have a new release that also contains the Acceleration and skidpad tracks, could you build this? If not I will try again in a couple of days.