-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 Humble compatibility #317
ROS2 Humble compatibility #317
Conversation
Hi @b1n-ch1kn, How do you currently connect to the sim in WSL2? I know you can open some ports in your windows firewall and can use the |
Hi @wouter-heerwegh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just remove the comments and we'll be ready to merge
Hi @b1n-ch1kn, I used this code to always set the IP of my host machine. I am however not able to connect to the simulator without disabling my firewall. Are you running windows 11? Or did you do something specifically to open ports?
|
Ok cool. I use Windows 10 and 11 actually (laptop/desktop) and the rest of my team is also fairly split. I don't think we've ever had port or firewall issues and I havent had to disable Windows firewall. I know when you first open the sim .exe, it prompts if you'd like to use this in private vs public wifi areas, but other than that, it's mostly just worked fine specifying Actually, when running a VPN it breaks, so the bridge won't detect the sim running. |
This has been tested on Humble and Galactic in Ubuntu 20.04, WSL2.
These were problematic lines stopping the bridge from
colcon
building in Humble, but maintains backwards compatibility.As mentioned in #296 there may be further compatibility issues with Ubuntu 22.04 that can be addressed in a future PR.