Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Humble compatibility #317

Merged

Conversation

b1n-ch1kn
Copy link
Contributor

This has been tested on Humble and Galactic in Ubuntu 20.04, WSL2.
These were problematic lines stopping the bridge from colcon building in Humble, but maintains backwards compatibility.

As mentioned in #296 there may be further compatibility issues with Ubuntu 22.04 that can be addressed in a future PR.

@wouter-heerwegh
Copy link
Member

Hi @b1n-ch1kn,

How do you currently connect to the sim in WSL2? I know you can open some ports in your windows firewall and can use the host parameter to specify where the simulator is running, but I don't like this approach.

@b1n-ch1kn
Copy link
Contributor Author

Hi @wouter-heerwegh
Yeah the only way we've been able to get the bridge in WSL2 to connect to the sim is to specify 'host:= '
It's not the worst thing, but can be annoying on a laptop when IPs change depending on what building you're in. Haven't tried the firewall port method, but could be looked into at some point.

Copy link
Contributor

@mateusz-lichota mateusz-lichota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove the comments and we'll be ready to merge

ros2/src/fsds_ros2_bridge/include/airsim_ros_wrapper.h Outdated Show resolved Hide resolved
@wouter-heerwegh
Copy link
Member

Hi @b1n-ch1kn,

I used this code to always set the IP of my host machine. I am however not able to connect to the simulator without disabling my firewall. Are you running windows 11? Or did you do something specifically to open ports?

if [ ! -n "$(grep -P "[[:space:]]winhost" /etc/hosts)" ]; then
        printf "%s\t%s\n" "$winhost" "winhost" | sudo tee -a "/etc/hosts"
fi

@b1n-ch1kn
Copy link
Contributor Author

b1n-ch1kn commented Sep 1, 2022

Ok cool. I use Windows 10 and 11 actually (laptop/desktop) and the rest of my team is also fairly split. I don't think we've ever had port or firewall issues and I havent had to disable Windows firewall. I know when you first open the sim .exe, it prompts if you'd like to use this in private vs public wifi areas, but other than that, it's mostly just worked fine specifying host_ip.

Actually, when running a VPN it breaks, so the bridge won't detect the sim running.

@mateusz-lichota mateusz-lichota merged commit 1de4e72 into FS-Driverless:master Sep 3, 2022
@b1n-ch1kn b1n-ch1kn deleted the ros2-humble-fixes branch September 3, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants