Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Humble 22.04 #327

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

b1n-ch1kn
Copy link
Contributor

Sim runs on Humble on 22.04 🥳 Also has backwards compatibility with Galactic on 20.04.
See related PR for fs_msgs FS-Driverless/fs_msgs#6

@mateusz-lichota
Copy link
Contributor

mateusz-lichota commented Sep 4, 2022

The build seems to be failing in the github workflow because it runs on Ubuntu 18.04, which doesn't support the newer clang. How about changing the runner version to 20.04?

@mateusz-lichota mateusz-lichota added the enhancement New feature or request label Sep 4, 2022
@wouter-heerwegh
Copy link
Member

wouter-heerwegh commented Sep 14, 2022

I have a fix for the workflow but can't push it because I have no access to the QUT-Motorsport fork? @b1n-ch1kn is it blocked in some way?

I think we should keep the workflow working for 18.04, as people might still be using ROS Melodic. I'll make a pull request later to also add a workflow for noetic, galactic and humble on 20.04 and 22.04.

@b1n-ch1kn
Copy link
Contributor Author

Hmm, @wouter-heerwegh if you're pushing direct to that fork it might be because it's organisation locked. If you'd like I could add the changes and commit here? Or I could push the forked branch to a new branch here so you could add changes?

@b1n-ch1kn
Copy link
Contributor Author

b1n-ch1kn commented Sep 15, 2022

Reopening with maintainer editing
Update it didn't work :(

@b1n-ch1kn b1n-ch1kn closed this Sep 15, 2022
@b1n-ch1kn b1n-ch1kn reopened this Sep 15, 2022
@b1n-ch1kn
Copy link
Contributor Author

Yay, this passed the workflow

@wouter-heerwegh wouter-heerwegh merged commit c0b5580 into FS-Driverless:master Sep 15, 2022
@b1n-ch1kn b1n-ch1kn deleted the ros2-humble-2204 branch September 15, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants