Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart() function to reset the cones and the vehicle to their original starting state #348

Closed
wants to merge 8 commits into from

Conversation

MattBrth
Copy link

I think AirSim was missing a function to reset the cones that's why I implemented this.

Here is how it works:
RestartLevel() was a member of player_controller but I managed to access it from the WorldSim instance with the added function ASimModeBase::restart() in the SimModeBase.cpp module.
I then connected this function to the RcpLibClient to be called by the python client.

@MattBrth MattBrth marked this pull request as ready for review November 15, 2022 03:14
@wouter-heerwegh
Copy link
Member

Hi @MattBrth

Thanks for the implementation. I made some changes aswell to implement a ros1 service to call it, but I was not able to push these changes to this pull request. Could it be possible to enable edits by maintainers on this PR so I can add them here? Otherwise I will close this and open a new PR between a branch on this repo an the master branch.

I saw you added an acceleration map to the maps folder. Is this the standard Acceleration map that is provided within the simulator, or did you add one yourself?

@MattBrth MattBrth marked this pull request as draft November 24, 2022 19:59
@MattBrth
Copy link
Author

MattBrth commented Nov 24, 2022

@wouter-heerwegh I forgot to revert the map folder ... Unfortunately I don't have the box " Allow edits from maintainers." even when I try to recreate another PR. Do you know why ?

@wouter-heerwegh
Copy link
Member

Most likely because the repo is forked on your organization and I probably don't have rights to work on it

@MattBrth
Copy link
Author

@wouter-heerwegh Ok so I should create a branch in this repo and open my PR in it ?

@MattBrth
Copy link
Author

@wouter-heerwegh well i saw you already did it on your branch :)

@wouter-heerwegh
Copy link
Member

@MattBrth yes, so we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants