Fix disk shrink failure from missing disk image and partition objects #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, `Mount-DiskImage` passthru will sometimes have a null value for the `DiskNumber` property, so this is piped into `Get-DiskImage` to preserve all properties.
Partition information (`$partinfo`) would fail silently, because when `Get-Partition -DiskNumber $mountedDisk.Number -ErrorAction Stop` only returns `$null`, but does not register as an exception, so the `catch {}` blocks would never fire. Instead, this is now partially handled through if statements.
Without these changes, in certain cases the script would execute, but not actually shrink any disks, and it would output that it could not get partition information in the logfile.
|
THANK YOU!!!!!! I was able to use this script to finally get all of my Profiles compressed! I would really recommend reviewing this for a new final release. I am so grateful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution I found for when disk shrinking fails, and says it cannot get partition information: #43 (comment)
For some reason,
Mount-DiskImagepassthru will sometimes have a null value for theDiskNumberproperty, so this is piped intoGet-DiskImageto preserve all properties.Partition information (
$partinfo) would fail silently, because whenGet-Partition -DiskNumber $mountedDisk.Number -ErrorAction Stoponly returns$null, but does not register as an exception, so thecatch {}blocks would never fire. Instead, this is now partially handled through if statements.Without these changes, in certain cases the script would execute, but not actually shrink any disks, and it would output that it could not get partition information in the logfile.