Fix broken Windows install #12

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@andrew-d

andrew-d commented Mar 3, 2012

The extra slashes in the MANIFEST.in file broke the install on Windows. sundown still doesn't compile properly - I'm going to send a pull request for that too, shortly.

@andrew-d

This comment has been minimized.

Show comment
Hide comment
@andrew-d

andrew-d Mar 3, 2012

Ok, just added the commit that should fix Windows installs - it works on my Windows 7 x64 machine.

andrew-d commented Mar 3, 2012

Ok, just added the commit that should fix Windows installs - it works on my Windows 7 x64 machine.

@FSX

This comment has been minimized.

Show comment
Hide comment
@FSX

FSX Mar 3, 2012

Owner

I can't merge the changes in the Sundown files, because Sundown is pulled in as a submodule now. You should send a pull request to the Sundown repository. The changes to the manifest file when I get home.

Doesn't it compile on Windows (which compiler)? I managed to compile it MinGW, but that was with 0.4.0.

Owner

FSX commented Mar 3, 2012

I can't merge the changes in the Sundown files, because Sundown is pulled in as a submodule now. You should send a pull request to the Sundown repository. The changes to the manifest file when I get home.

Doesn't it compile on Windows (which compiler)? I managed to compile it MinGW, but that was with 0.4.0.

@andrew-d

This comment has been minimized.

Show comment
Hide comment
@andrew-d

andrew-d Mar 3, 2012

Ah, ok. I think there's actually an issue open at sundown now asking for Windows support. I was trying to compile with the Visual Studio compilers, but they don't support C99 properly.

andrew-d commented Mar 3, 2012

Ah, ok. I think there's actually an issue open at sundown now asking for Windows support. I was trying to compile with the Visual Studio compilers, but they don't support C99 properly.

@FSX

This comment has been minimized.

Show comment
Hide comment
@FSX

FSX Mar 3, 2012

Owner

Your changes are different from the changes in the pull request for Sundown. I don't know much about VS though.

Owner

FSX commented Mar 3, 2012

Your changes are different from the changes in the pull request for Sundown. I don't know much about VS though.

@andrew-d

This comment has been minimized.

Show comment
Hide comment
@andrew-d

andrew-d Mar 3, 2012

Yeah, that pull request adds a bunch of project files and such. I sent one of my own - I think it's a "cleaner" solution :-)

andrew-d commented Mar 3, 2012

Yeah, that pull request adds a bunch of project files and such. I sent one of my own - I think it's a "cleaner" solution :-)

@FSX FSX closed this Mar 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment