-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing universes from Tot and GTot comps #2785
Conversation
runlim regresion slopes for time and space for |
Thanks @aseemr! Just some context: The internal abstract syntax in the compiler maintained an In an earlier PR, when we were reflecting universes into the FStar.Reflection syntax, we added this universe field to the reflection counterparts of Tot and GTot, i.e., So, this PR systematically removes the universes argument from the internal compiler representation of Tot and GTot, and correspondingly also from Note, in doing so, we also took the opportunity to clean up the reflection of the decreases clause in Tot and GTot computation types--they are no longer present there, but are added to the representation of |
This PR removes universes from Tot and GTot computation types in reflection and typechecker syntax.
Total
andGTotal
cases take only one argument, the result type of the computation.C_Total
andC_GTotal
to the commonC_Eff
case.It is a breaking change for the reflection clients, see
tests
changes in the PR for a few examples.There is no performance impact, see the regression graphs below in the comments.