Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #167 #180

Merged
merged 1 commit into from Aug 5, 2019
Merged

Fix #167 #180

merged 1 commit into from Aug 5, 2019

Conversation

FWDekker
Copy link
Owner

@FWDekker FWDekker commented Aug 5, 2019

Fixes #167.

  • Adds the option to add a custom TableCellEditor to a Column in JCheckBoxTable.
  • Uses IntelliJ's LocalPathCellEditor to edit paths with.
  • Moves validation from the addDictionaries method to the doValidate method.
  • Validates all dictionaries instead of only active dictionaries.
  • Fixes an issue where an exception is thrown if a row that is being edited is removed.

@FWDekker FWDekker added the feature New feature or request label Aug 5, 2019
@FWDekker FWDekker self-assigned this Aug 5, 2019
@FWDekker FWDekker merged commit a4ad629 into master Aug 5, 2019
@FWDekker FWDekker deleted the editable-dictionaries branch August 5, 2019 14:43
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #180 into master will increase coverage by 2.37%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     72.75%   75.12%   +2.37%     
- Complexity      218      222       +4     
============================================
  Files            33       33              
  Lines           789      780       -9     
  Branches         80       81       +1     
============================================
+ Hits            574      586      +12     
+ Misses          199      177      -22     
- Partials         16       17       +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing dictionaries
1 participant