Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyledTextAreaBehaviorTest fail #454

Closed
msarmc opened this issue Mar 16, 2017 · 4 comments
Closed

StyledTextAreaBehaviorTest fail #454

msarmc opened this issue Mar 16, 2017 · 4 comments

Comments

@msarmc
Copy link

msarmc commented Mar 16, 2017

I'm trying to build the latest version and I get the following error.

org.fxmisc.richtext.model.StyledTextAreaBehaviorTest > org.fxmisc.richtext.model.StyledTextAreaBehaviorTest$ContextMenuTests.requestingContextMenuViaKeyboardWorksOnWindows
FAILED
java.lang.AssertionError at StyledTextAreaBehaviorTest.java:86

Is there a setting I'm missing or something?

@JordanMartinez
Copy link
Contributor

Hmm... That might just be a flaky test since the mouse version of it works fine.

@JordanMartinez
Copy link
Contributor

I've looked into this issue more. It looks like TestFX does not properly create a ContextMenuEvent when the line push(KeyEvent.CONTEXT_MENU) is called. I added println statements to the area's setOnKey[Pressed/Released/Typed] handlers and only the released one was called. They're moving from using the internal API they use to create events to using Event.fireEvent to create such events. That migration will be complete in the next release I'm sure. So, for now, let's just ignore the test since the code does work as proven by the mouse event tests. We can enable it again when the TestFX issue is fixed.

@JordanMartinez
Copy link
Contributor

See also TestFX/TestFX#374

@JordanMartinez
Copy link
Contributor

@msarmc Please use the updated master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants