Refactor CapsuleMesh #126
Merged
Refactor CapsuleMesh #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these refactors, I'm noticing use of PI, cos, sin, etc. math functions that constantly get converted to float. I think for readability's sake it would be beneficial to extract a small subset of Math into corresponding MathF (F for float) class. -- will open an issue for this
Re: order of properties vs
updateMesh() / createMesh(). Given properties, when invalidated, call updateMesh(), I think it feels more natural to have properties first, then update/create mesh. Plus, from reader's perspective, all constructor / property code is trivial, so can skim through quickly until the end of file, where all complex update/create mesh goes. Let me know if you agree.