create FXyz-Importers #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Included .obj importer from 3DViewer
remove unnecessary files
This was referenced Oct 14, 2018
|
Except for package declarations and build/config files, did you make any changes to the 3DViewer files? |
|
No, basically I've just moved classes, I just wanted to have a first PR in place. We can discuss required changes and improvements once we have the 3DViewer importers transferred. |
nlisker
approved these changes
Oct 15, 2018
|
Are you waiting for another review or can it be merged? |
|
@nlisker I've just merged it. I will start adding the Maya importer now. The DAE importer doesn't really work for the samples I've tested so it will required more time to review it before including it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the obj importer from the 3DViewer project, adds PolygonMesh and related classes to FXyz-Core, and includes a sample to FXyz-Samples with a 3D model from the Duke repository.