This repository has been archived by the owner on May 8, 2024. It is now read-only.
Configuration for Codeac.io #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYWinds
added a commit
that referenced
this pull request
Oct 6, 2022
FYWinds
added a commit
that referenced
this pull request
Oct 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @FYWinds
I briefly looked up your repo and saw a good amount of work over here. Good job! 馃
You recently also tried Codeac.io and you probably haven't had the best experience just because of lack of correct configuration. It's caused by showing a lot of false positives at Codeac.io.
Storing external dependencies or generated files is usually not the best practice. It's better to generate/download them dynamically in your Continuous Integration pipeline.
So I added the .eslintignore file which solves this problem and skips the analyses at the folders listed there.
Let me know if you need any more help.
Jiri Tichy
Business Developer @Codeac.io
PS: Keep doing open-source, please! We all appreciate your work a lot! :)