Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest unparcellated_regions from map specs #435

Closed
wants to merge 1 commit into from

Conversation

AhmetNSimsek
Copy link
Collaborator

Although some regions are defined in a map configuration with indices (for accuracy), they do not correspond to any regions in the corresponding region. (see https://github.com/FZJ-INM1-BDA/siibra-python/actions/runs/5740796548/job/15559446484?pr=373)
For example, on fsaverage space Julich brain 3 have indices for the following regions but they are not part of the Julich brain 3 region tree.

"unparcellated regions": [
	"BrainStemMask - right hemisphere",
	"BrainStemMask - left hemisphere",
	"CorpusCallosumMask - right hemisphere",
	"CorpusCallosumMask - left hemisphere"
]

This PR allows digesting fields such as one above from map configurations and when a use ones to get the region object for their corresponding index, it informs the users and returns None (the same action for when there are not matches).
Also, it allows the parcellationmap.Map.get_colormap method to skip such regions. (While they might have a color value, the colors are currently defined in parcellation configurations.)

@AhmetNSimsek AhmetNSimsek added enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related. labels Aug 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #435 (1822403) into main (5a0e6b3) will increase coverage by 0.08%.
Report is 66 commits behind head on main.
The diff coverage is 26.45%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   36.81%   36.90%   +0.08%     
==========================================
  Files          61       61              
  Lines        5421     5528     +107     
==========================================
+ Hits         1996     2040      +44     
- Misses       3425     3488      +63     
Files Changed Coverage Δ
siibra/configuration/configuration.py 42.35% <ø> (ø)
siibra/configuration/factory.py 22.22% <0.00%> (+0.24%) ⬆️
siibra/core/atlas.py 85.71% <ø> (+1.23%) ⬆️
...a/features/connectivity/functional_connectivity.py 55.55% <0.00%> (ø)
siibra/locations/boundingbox.py 19.88% <ø> (ø)
siibra/volumes/neuroglancer.py 21.42% <0.00%> (ø)
siibra/volumes/volume.py 50.29% <0.00%> (ø)
siibra/features/tabular/tabular.py 24.32% <3.84%> (-5.68%) ⬇️
...a/features/tabular/receptor_density_fingerprint.py 26.19% <4.54%> (-2.02%) ⬇️
siibra/features/tabular/cortical_profile.py 29.87% <5.88%> (-0.80%) ⬇️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AhmetNSimsek
Copy link
Collaborator Author

An alternative has been employed so that no changes in siibra-python is necessary:

The regions that are indexed but not defined in the region tree are now listed under unindexed_indices in the map configurations. This field could be potentially digested by siibra-python but first the need has to be apparent.

@AhmetNSimsek AhmetNSimsek deleted the unparcellatedRegions branch August 16, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants