Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test examples as a part of e2e. Create docs on push/PR to main and on publish #592

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

No description provided.

Copy link
Member

@xgui3783 xgui3783 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since .github/workflows/docs.yml also runs examples, IMO, it makes more sense to run examples in .github/workflows/docs.yml exclusively.

We could rename the workflow as examples-and-build-doc

.github/workflows/docs.yml Outdated Show resolved Hide resolved
e2e/test_examples.py Show resolved Hide resolved
@AhmetNSimsek
Copy link
Collaborator Author

since .github/workflows/docs.yml also runs examples, IMO, it makes more sense to run examples in .github/workflows/docs.yml exclusively.

We could rename the workflow as examples-and-build-doc

But then artifacts will be uploaded for no reason and if sphinx-build fails due to sphinx/documentation-related issues, the examples won't be passing.

e2e/test_examples.py Outdated Show resolved Hide resolved
…mples with e2e test suite and choose python version accordingly
@AhmetNSimsek AhmetNSimsek merged commit 6103fd0 into main Apr 26, 2024
27 of 35 checks passed
@AhmetNSimsek AhmetNSimsek deleted the test_examples_in_e2e branch April 26, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants