Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a tag repository, with a few helpful methods #1

Merged
merged 2 commits into from
Sep 18, 2011

Conversation

weaverryan
Copy link
Contributor

Hey Fabien!

This repository should be generic enough, and hopefully quite helpful. It's probably not perfect, but a good start. A few comments:

  • I'm not exactly sure why we have the "name" field in the extension, but then a "slug" field in the bundle. I understand the idea of normalizing all the tags, but it seems like we should do that in the extension (not just in the bundle). To allow the bundle to work later, I've added a tagQueryField property to the TagRepository so that we eventually create a TagRepository in the bundle, which subclasses this one and changes that property to slug.
  • As mentioned above, once we're happy with this, some changes should be made to the bundle (and its documentation) so that this works easily there as well.

Thanks!

FabienPennequin pushed a commit that referenced this pull request Sep 18, 2011
Introducing a tag repository, with a few helpful methods
@FabienPennequin FabienPennequin merged commit 2caa28c into FabienPennequin:master Sep 18, 2011
@FabienPennequin
Copy link
Owner

Thanks Ryan!

@weaverryan
Copy link
Contributor Author

@FabienPennequin What about the name and slug field? What's the purpose of having a name field in the extension, but then a slug field in the bundle?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants