General improvements.

FabriBertani · Jan 3, 2024 · d6d6da1 · d6d6da1
1 parent f997a11
commit d6d6da1
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 8 deletions.
diff --git a/Plugin.Maui.AppRating/AppRating.net.cs b/Plugin.Maui.AppRating/AppRating.net.cs
@@ -0,0 +1,20 @@
+
+namespace Plugin.Maui.AppRating;
+
+partial class AppRatingImplementation : IAppRating
+{
+    public Task PerformInAppRateAsync(bool isTestOrDebugMode)
+    {
+        throw new NotImplementedException();
+    }
+
+    public Task PerformRatingOnStoreAsync(string appId)
+    {
+        throw new NotImplementedException();
+    }
+
+    public Task PerformRatingOnStoreAsync(string packageName = "", string applicationId = "", string productId = "")
+    {
+        throw new NotImplementedException();
+    }
+}
diff --git a/Plugin.Maui.AppRating/Platforms/MacCatalyst/AppRating.maccatalyst.cs b/Plugin.Maui.AppRating/Platforms/MacCatalyst/AppRating.maccatalyst.cs
@@ -15,11 +15,9 @@ public Task PerformInAppRateAsync(bool isTestOrDebugMode)
 
         if (UIDevice.CurrentDevice.CheckSystemVersion(14, 0))
         {
-            var windowScene = UIApplication.SharedApplication?.ConnectedScenes?
+            if (UIApplication.SharedApplication?.ConnectedScenes?
                 .ToArray<UIScene>()?
-                .FirstOrDefault(ws => ws.ActivationState == UISceneActivationState.ForegroundActive) as UIWindowScene;
-
-            if (windowScene != null)
+                .FirstOrDefault(ws => ws.ActivationState == UISceneActivationState.ForegroundActive) is UIWindowScene windowScene)
             {
                 SKStoreReviewController.RequestReview(windowScene);
 

diff --git a/Plugin.Maui.AppRating/Platforms/iOS/AppRating.ios.cs b/Plugin.Maui.AppRating/Platforms/iOS/AppRating.ios.cs
@@ -1,5 +1,6 @@
 using Foundation;
 using StoreKit;
+using System.Runtime.Versioning;
 using UIKit;
 
 namespace Plugin.Maui.AppRating;
@@ -17,11 +18,9 @@ public Task PerformInAppRateAsync(bool isTestOrDebugMode)
         {
             if (UIDevice.CurrentDevice.CheckSystemVersion(14, 0))
             {
-                var windowScene = UIApplication.SharedApplication?.ConnectedScenes?
+                if (UIApplication.SharedApplication?.ConnectedScenes?
                     .ToArray<UIScene>()?
-                    .FirstOrDefault(ws => ws.ActivationState == UISceneActivationState.ForegroundActive) as UIWindowScene;
-
-                if (windowScene != null)
+                    .FirstOrDefault(ws => ws.ActivationState == UISceneActivationState.ForegroundActive) is UIWindowScene windowScene)
                 {
                     SKStoreReviewController.RequestReview(windowScene);
 
@@ -31,7 +30,9 @@ public Task PerformInAppRateAsync(bool isTestOrDebugMode)
                 }
             }
 
+#pragma warning disable CA1422
             SKStoreReviewController.RequestReview();
+#pragma warning restore CA1422
 
             tcs.SetResult(true);
         }