Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 17 fix #22

Merged
merged 3 commits into from
Mar 16, 2024
Merged

iOS 17 fix #22

merged 3 commits into from
Mar 16, 2024

Conversation

Gogzs
Copy link
Contributor

@Gogzs Gogzs commented Mar 9, 2024

This should resolve #18
Tested on two devices (iPhone SE 2023 and iPhone 14) updated to the latest iOS version.
Might be turned into a one liner, but you get the gist of what's the solution.

Thanks for the great work with this plugin, would be nice if this could get published anytime soon as 1.1.6.

Best regards

@FabriBertani FabriBertani self-requested a review March 10, 2024 19:42
Copy link
Owner

@FabriBertani FabriBertani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gogzs, thank you so much for your support and this fix, I really appreciate it.

I leave you a few comments on your code to do before accepting and merging this PR.

@Gogzs
Copy link
Contributor Author

Gogzs commented Mar 11, 2024

I think this should do it, thanks for the input and all the work.

Copy link
Owner

@FabriBertani FabriBertani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 😃.

@FabriBertani FabriBertani merged commit 2edd747 into FabriBertani:main Mar 16, 2024
@freakmacleod
Copy link

I just tested the 1.1.6 release of your NuGet with this iOS fix implemented and its not working for me. Screenshot is still possible to take. Do I need to config something for covering the content before screenshot? Im just activating the protection with the static function. @FabriBertani @Gogzs

@denhaandrei
Copy link

denhaandrei commented Mar 19, 2024

I just tested the 1.1.6 release of your NuGet with this iOS fix implemented and its not working for me. Screenshot is still possible to take. Do I need to config something for covering the content before screenshot? Im just activating the protection with the static function. @FabriBertani @Gogzs

Issue with images in the package, quick fix add images to your project:
#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 17.0.3 not working
4 participants