Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enigma crashes when saving for the first time from the unsaved changes dialog #533

Closed
Juuxel opened this issue Oct 5, 2023 · 0 comments · Fixed by #532
Closed

Enigma crashes when saving for the first time from the unsaved changes dialog #533

Juuxel opened this issue Oct 5, 2023 · 0 comments · Fixed by #532
Assignees
@Juuxel

Comments

@Juuxel
Copy link
Member

Juuxel commented Oct 5, 2023

(I'll fix this myself)

Steps to reproduce:

  1. Open a jar in Enigma without mappings
  2. Map some names
  3. Try to close Enigma, then choose to save mappings when it warns you about unsaved changes
Juuxel added a commit to Juuxel/Enigma that referenced this issue Oct 5, 2023
@Juuxel
Fix NPE by using Enigma directories as the default mapping format
31fc517 
Fixes FabricMC#533.
@Juuxel Juuxel mentioned this issue Oct 5, 2023
Merged
modmuss50 pushed a commit that referenced this issue Apr 6, 2024
@Juuxel @NebelNidas
Add file extensions to open and save dialogs (#532)
3030b64 
* Add file extensions to Save As dialog

* Include leading dots in file extensions for simplicity

* Add file extensions to open mappings dialogs

* Remove unused tinyMappingsFileChooser

* Use the same file chooser for all mapping IO

* Fix NPE by using Enigma directories as the default mapping format

Fixes #533.

* Fix code style

* Allow .mappings extension for single Enigma files

* gradlew.bat

---------

Co-authored-by: NebelNidas <nebelnidas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Juuxel Juuxel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add file extensions to open and save dialogs Juuxel/Enigma
1 participant
@Juuxel