I18N fixes: Fallback translations #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
modmuss50
reviewed
Feb 18, 2024
modmuss50
reviewed
Feb 18, 2024
modmuss50
reviewed
Feb 18, 2024
| "vitepress": "^1.0.0-rc.33", | ||
| "vitepress-versioning-plugin": "^0.10.0", | ||
| "vue": "^3.4.0" | ||
| "patch-package": "^8.0.0", |
There was a problem hiding this comment.
is this not a devDependencies?
There was a problem hiding this comment.
Potentially? I didn't test if it worked as a devDependency
IMB11
added
the
framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a patch to apply vuejs/vitepress#3312 to vitepress, this should work on all future vitepress versions (until 1.0.0, but by then, the PR is likely merged) - this was recommended by the vitepress maintainer as a workaround solution that will work in the long term.
Also fixes URLs on the sidebar by prepending the locale URL.