Verify intermediary version #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maityyy
reviewed
Dec 16, 2021
| return id; | ||
| } | ||
|
|
||
| public String getName() { |
There was a problem hiding this comment.
Fabric Loader is 100% Java 8
There was a problem hiding this comment.
Fabric Loader is 100% Java 8
for compatibility with older versions of MC?
There was a problem hiding this comment.
yes, don't want to introduce incompatibility with old versions or old hardware (e.g. old intel on windows) for such little gain
thecatcore
approved these changes
Jan 2, 2022
modmuss50
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if the intermediary jar is correct for the MC version being used.
wip