Add SLF4J adapter, refactor lib classification #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Jan 19, 2022
liach
reviewed
Jan 20, 2022
| method.invoke(null, (Object) new String[0]); | ||
| urls = BundlerClassPathCapture.FUTURE.get(10, TimeUnit.SECONDS); | ||
|
|
||
| Thread.currentThread().setContextClassLoader(prevCl); |
There was a problem hiding this comment.
Should these restoration code be put into a finally clause in case the main method invocation or the future execution throws anything?
There was a problem hiding this comment.
good point, the ClassNotFoundException path may not be restored fully otherwise.
liach
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.