Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case with early snapshot version detection #897

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix edge case with early snapshot version detection #897

merged 1 commit into from
Feb 13, 2024

Commits on Jan 24, 2024

  1. Fix edge case with early snapshot version detection 

    Between 1.2 and the mid-1.7s, Mojang had a weird versioning system where pre-releases would 'reserve' a version number, and if additional pre-releases were required, the version number would be bumped. This led to some minor versions being 'skipped'.
This was not previously accounted for in the version detection for snapshots.
The snapshot 12w42b, for example, was followed by 1.4 pre-release, and 1.4.1 pre-release, before 1.4.2 became the first stable 1.4.x version. Previously, 12w42b would have been detected by Loader as a 1.4.2 snapshot - technically correct, but would have made its semver place it *after* 1.4 and 1.4.1, which is incorrect.
This PR fixes all such cases.
    @Shnupbups
    Shnupbups committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e8b9558 View commit details
    Browse the repository at this point in the history