Support non-semver game versions #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
approved these changes
Apr 3, 2024
NebelNidas
approved these changes
Apr 7, 2024
There was a problem hiding this comment.
It is a welcome change, though I fear users suffering from the inevitable crashes / incompatible mod set errors caused by this are going to be quite confused as to what the root cause is (logs aren't particularly discoverable for the average MC player). It would be advisable to have the GUI display a corresponding warning as well in cases of potentially related mod resolution errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow running Loader for weird MC releases, with limited mod -> game version range comparison support of course.
It logs a warning in production, but throws an error in-dev since devs are more able to use the system property and we don't want to miss the limited normalization support.