Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla Bug: Glowstone creates AO shade #199

Closed
grondag opened this issue May 20, 2019 · 3 comments
Closed

Vanilla Bug: Glowstone creates AO shade #199

grondag opened this issue May 20, 2019 · 3 comments
Assignees
@grondag
Labels
bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api

Comments

@grondag
Copy link
Contributor

grondag commented May 20, 2019

Block.getAmbientOcclusionLightLevel() only checks for the block being a full cube and so the result is this.

https://i.imgur.com/wkLrnF3.png

This could be fixed with an additional check in Indigo. But should it be?

(Hat tip to @InsomniaKitten for the find.)
@asiekierka
Copy link
Contributor

We've already done some AO fixes, no? With a way to toggle between "emulate vanilla", "emulate vanilla for non-Fabric models, fix bugs for Fabric models" and "fix bugs for all models", with that last bit being the default, IIRC. I would just put this "additional check" under the same "fix bugs?" check.

@grondag
Copy link
Contributor Author

grondag commented May 20, 2019

Alright. Is there any supported way to expose configuration options for API yet?

@asiekierka
Copy link
Contributor

No, but implementing the check in the right place will allow to expose it a bit later.

@Prospector Prospector added bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api labels Jun 3, 2019
@grondag grondag self-assigned this Jul 4, 2019
grondag added a commit to grondag/fabric that referenced this issue Jul 6, 2019
@grondag
Option to prevent luminous blocks from casting AO shade
01101d3 
Disabled by default.  Addresses FabricMC#199
@grondag grondag mentioned this issue Jul 6, 2019
Closed
@grondag grondag added the in progress This issue has PR(s) open to resolve it (or a PR that is WIP) label Jul 6, 2019
@asiekierka asiekierka removed the in progress This issue has PR(s) open to resolve it (or a PR that is WIP) label Jul 7, 2019
ThalusA pushed a commit to ThalusA/fabric that referenced this issue May 31, 2022
@grondag @asiekierka
Various Indigo Improvements (FabricMC#295)
75c6fdd 
- Fix FabricMC#199 Vanilla Bug: Glowstone creates AO shade
- Fix FabricMC#289 Rendering on the Cutout and Transparent Layers together interferes with water rendering
- Fix FabricMC#290 Smooth lighting breaks on continuous angled surfaces
- Fix FabricMC#291 QuadEmitter not cleared on MeshBuilder.build()
- Fix FabricMC#292 Render context QuadEmitter crash with flat lighting
- Fix FabricMC#293 Relax vertex order requirements for modded quads
- Fix swapped color components for grass and other blocks
- Add option to partially support non-standard vertex formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grondag grondag

Labels
bug Something isn't working indigo Pull requests and issues related to Indigo's implementation of the rendering api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asiekierka @grondag @Prospector