Add BlockBreakEffectsCallback

[TheBrokenRail]

Sometimes you might not want the block break particles and sounds to appear for a block. However, the only good way to do this (if you want access to the breaking entity) is a @Redirect in World#breakBlock. This has already caused a conflict between Magna and EnergonRelics.

		BlockBreakEffectsCallback.EVENT.register((world, breakingEntity, pos) -> {
			BlockState state = world.getBlockState(pos);
			return state.getBlock() == Blocks.BEDROCK ? ActionResult.FAIL : ActionResult.PASS;
		});

[Geometrically]

Should probably add a testmod too

[TheBrokenRail]

I did add a testmod though?

[Vaerian]

Everything looks good code wise, but I guess I just wonder if maybe the two events ought to be separated. Because both methods are using the same event signature it means we're limited to the common information between the two methods and we're missing out on some extra information that could be useful in certain situations. I guess it really comes down to the comment I made at the BlockMixin, I don't specifically know what each of these methods have in terms of parameters, so I don't know what kind of useful information they might be able to relay to the event. You know these methods better than I do, so if you think someone might benefit from having those additional variables passed in then I might recommend the two events get separated for greater control.

[TheBrokenRail]

What do you mean? There isn't any information that isn't common between the two mixins. They both have the entity that broke the block, the position of the block, the block state, and the world. The Block.onBreak mxin only has two world and two players because of how @Redirects work, they are literally the same object. player == player2

[TheBrokenRail]

Is there anything else I should do?

[i509VCB]

Upon further consideration, I believe the block mixin will suffice.

[TheBrokenRail]

Any update on this? Should I rebaee it on 1.17?

[i509VCB]

Keep this on 1.16, we can cherry pick at merge time