Fix Programmer Art injection support (1.19.2) #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
approved these changes
Mar 8, 2023
apple502j
added
bug
modmuss50
approved these changes
Mar 15, 2023
modmuss50
pushed a commit
that referenced
this pull request
Mar 15, 2023
(cherry picked from commit edbdcdd)
EnnuiL
pushed a commit
to QuiltMC/quilted-fabric-api
that referenced
this pull request
Mar 26, 2023
* Indigo shade related fixes and other changes (FabricMC#2898) * Apply disabled shade from vanilla quads directly to material - Remove QuadViewImpl.shade * Fix enhanced AO calculation and respect non-terrain culling state - Fix AoCalculator using AO face data computed with a potentially different shade state - Move non-cached computation code to separate method in AoCalculator - Turn AoCalculator's brightnessFunc and aoFunc into abstract methods - Do not check null check world in non-terrain AO calculation since it cannot be null - Pass through lightFace and shade state as method arguments in AoCalculator methods to prevent additional lookups - Do not check for the axis aligned flag in AbstractQuadRenderer.shadeFlatQuad - Respect cull parameter passed to non-terrain rendering by merging TerrainBlockRenderInfo into BlockRenderInfo - Use reusable search pos when calling Block.shouldDrawSide to prevent additional BlockPos allocation - Change BlockRenderContext.render and TerrainRenderContext.tessellateBlock to return void since return value is no longer used - Remove QuadViewImpl.vertexStart since it is unused * Add suggestions - Mark Direction parameter to BlockRenderInfo.shouldDrawFace as Nullable - Reuse MaterialFinder in FrameBakedModel (cherry picked from commit 3a95925) * Bump version * Fix FabricMC#2925: deprecate item functions in BlockRenderLayerMap (FabricMC#2930) (cherry picked from commit c2e6f67) (cherry picked from commit 928d44d) * Bump version * Update et_ee.json (FabricMC#2894) (cherry picked from commit 09aba06) * Add 'Windswept Hills' biome convention tag (FabricMC#2878) * add windswept biome tag * change windswept tag to windswept hills * list out biomes and revert name change (cherry picked from commit 1b66477) * Fixed end biome source injection (FabricMC#2940) (cherry picked from commit 348a9c6) (cherry picked from commit f1c68e5) * EquipmentSlotProvider: Add javadoc link to getPreferredEquipmentSlot (FabricMC#2935) (cherry picked from commit 09a3510) (cherry picked from commit 71b8257) * Conventional Biome Tags tweaks (FabricMC#2955) * Birch Forest Tag FabricMC#2330 * Fix FabricMC#2649 * Run datagen (cherry picked from commit 315602f) (cherry picked from commit 521b5c5) * Update pl_pl.json (FabricMC#2929) (cherry picked from commit 36d2fcc) (cherry picked from commit 8368a8b) * Update ko_kr.json (FabricMC#2927) (FabricMC#2941) * Update ko_kr.json * fix typo (cherry picked from commit 930b8d4) (cherry picked from commit eeb6cf3) * Create zh_cn.json (FabricMC#2945) (cherry picked from commit 9af20fd) (cherry picked from commit 93582b9) * Fix Programmer Art resource pack injection support (FabricMC#2956) * Bump version --------- Co-authored-by: PepperCode1 <44146161+peppercode1@users.noreply.github.com> Co-authored-by: modmuss50 <modmuss50@gmail.com> Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> Co-authored-by: Madis Otenurm <Madis0@users.noreply.github.com> Co-authored-by: Michael <53499406+TheDeathlyCow@users.noreply.github.com> Co-authored-by: TelepathicGrunt <40846040+telepathicgrunt@users.noreply.github.com> Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com> Co-authored-by: Maity <47220489+maityyy@users.noreply.github.com> Co-authored-by: Yoosk <yooskacz@gmail.com> Co-authored-by: Alpha <alphakr93@outlook.com> Co-authored-by: RawDiamondMC <rawdiamondmc@qq.com> Co-authored-by: Julian Burner <48808497+NebelNidas@users.noreply.github.com> Co-authored-by: Amirhan-Taipovjan-Greatest-I <51203385+amirhan-taipovjan-greatest-i@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Programmer Art injection support, which has been broken ever since 78a6342.