Fix data attachment testmod #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacobsjo
commented
Feb 11, 2024
jacobsjo
commented
- use marker file to determine first/second launch
- move FAR_CHUNK farther out, so there is no change it gets generated during spawn chunk generation & extra check to not crash when this is the case anyways.
modmuss50
approved these changes
Feb 11, 2024
Syst3ms
approved these changes
Feb 11, 2024
...ttachment-api-v1/src/testmod/java/net/fabricmc/fabric/test/attachment/AttachmentTestMod.java
Outdated
Show resolved
Hide resolved
|
Well while we're at it, there's also this typo and that should be it. |
Syst3ms
approved these changes
Feb 11, 2024
modmuss50
pushed a commit
that referenced
this pull request
Feb 12, 2024
* fix data attachment testmod: use marker file to determine first/second launch * fix typos * one more typo (cherry picked from commit 4e3ec63)
Syst3ms
pushed a commit
to Syst3ms/fabric
that referenced
this pull request
Feb 12, 2024
* fix data attachment testmod: use marker file to determine first/second launch * fix typos * one more typo
modmuss50
pushed a commit
to Syst3ms/fabric
that referenced
this pull request
Feb 13, 2024
* fix data attachment testmod: use marker file to determine first/second launch * fix typos * one more typo
modmuss50
pushed a commit
that referenced
this pull request
Feb 13, 2024
* fix data attachment testmod: use marker file to determine first/second launch * fix typos * one more typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.