Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty data attachments being saved. #3588

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

modmuss50
Copy link
Member

Ensure that empty or null data attachments are never saved or read to nbt.

@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Feb 12, 2024
Copy link
Contributor

@Syst3ms Syst3ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky oversight. Just make sure to fix checkstyle before merging.

@modmuss50 modmuss50 merged commit b90db57 into FabricMC:1.20.4 Feb 12, 2024
5 checks passed
modmuss50 added a commit that referenced this pull request Feb 12, 2024
* Fix empty data attachments being saved.

* Checkstyle

(cherry picked from commit b90db57)
Syst3ms pushed a commit to Syst3ms/fabric that referenced this pull request Feb 12, 2024
* Fix empty data attachments being saved.

* Checkstyle
modmuss50 added a commit to Syst3ms/fabric that referenced this pull request Feb 13, 2024
* Fix empty data attachments being saved.

* Checkstyle
modmuss50 added a commit that referenced this pull request Feb 13, 2024
* Fix empty data attachments being saved.

* Checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants