Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.5] Misc networking cleanup #3594

Merged
merged 3 commits into from
Feb 18, 2024
Merged

[1.20.5] Misc networking cleanup #3594

merged 3 commits into from
Feb 18, 2024

Conversation

modmuss50
Copy link
Member

  • Deduplicate some logic in the client play/common network addon.
  • (Slight breaking change) limit the lenght of a network channel name to 128.
  • Set a limit of 8192 channel, can be configured by a system prop.

@modmuss50 modmuss50 added fabric-networking Pull requests and issues related to the networking api cleanup labels Feb 15, 2024
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Feb 17, 2024
@modmuss50 modmuss50 merged commit ac5f717 into FabricMC:1.20.5 Feb 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haykam821 haykam821 haykam821 left review comments

Assignees
No one assigned
Labels
cleanup fabric-networking Pull requests and issues related to the networking api merge me please Pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@modmuss50 @haykam821