Improve handling of empty item groups in the creative menu #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty/non-displayable item groups are now put after all other groups and only then are they split into pages.
Fixed an issue where empty item groups could get selected when switching pages
modmuss50
approved these changes
Feb 17, 2024
modmuss50
pushed a commit
that referenced
this pull request
Feb 18, 2024
* Better handling of empty item groups in pagination Empty/non-displayable item groups are now put after all other groups and only then are they split into pages. * Serendipitious bugfix Fixed an issue where empty item groups could get selected when switching pages * checkstyle (cherry picked from commit f9b333c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3566. The bug was caused by item groups being distributed into pages without checking if they could even be displayed. This PR waits until they have been initialized to do that, and relegates non-displayable groups to the end of the list, making it so that old behavior functions correctly. Testmod has been augmented with a regression test.
By coincidence, another bug was fixed wherein empty item groups could sometimes be selected when switching pages.