Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unneeded OverlayVertexConsumerMixin #3613

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Feb 24, 2024

Mojang fixed this bug in https://bugs.mojang.com/browse/MC-193656. Detailed analysis of the fix:

  • Before 24w05a: the bottom-most pose's normal matrix in the PoseStack used for rendering contains the mouse rotation, then later on the rotation is inversed using the inverse normal matrix given to RenderSystem.setInverseViewRotationMatrix.
  • Starting from 24w05a: the mouse rotation does not appear in the normal matrix anymore.

The "numerical instability" is therefore gone from normal computations entirely, and we can remove this fix.

Tested that the original crumbling bug does not appear anymore when trying to break the octagonal column block from the FRAPI testmod.

Closes #3582.

@modmuss50 modmuss50 added merge me please Pull requests that are ready to merge port Porting existing code to a different version cleanup labels Feb 24, 2024
@modmuss50 modmuss50 merged commit a167fc4 into FabricMC:1.20.5 Feb 25, 2024
5 checks passed
@Technici4n Technici4n deleted the remove-decal-fix branch February 25, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup merge me please Pull requests that are ready to merge port Porting existing code to a different version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants