Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.20.5] Fix loot table provider not working after 24w09a port #3630

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[1.20.5] Fix loot table provider not working after 24w09a port #3630

merged 1 commit into from
Mar 4, 2024

Conversation

maityyy
Copy link
Contributor

@maityyy maityyy commented Mar 3, 2024

Use thenCompose instead of thenApply for the loot table provider because thenCompose is needed when we return CompletionStage (CompletableFuture)

@maityyy
Copy link
Contributor Author

maityyy commented Mar 3, 2024

Exactly the same in AdvancementProvider

@maityyy maityyy changed the title Fix loot table provider not working Fix loot table provider not working after 24w09a Mar 3, 2024
@maityyy maityyy changed the title Fix loot table provider not working after 24w09a Fix loot table provider not working after 24w09a port (only bug 1.20.5) Mar 3, 2024
@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. labels Mar 3, 2024
@modmuss50 modmuss50 changed the title Fix loot table provider not working after 24w09a port (only bug 1.20.5) [1.20.5] Fix loot table provider not working after 24w09a port Mar 3, 2024
@modmuss50 modmuss50 merged commit fc9addb into FabricMC:1.20.5 Mar 4, 2024
5 checks passed
@maityyy maityyy mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

@Juuxel Juuxel Juuxel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maityyy @modmuss50 @Juuxel