Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address remaining typos and issues with new tags #3720

Merged
merged 3 commits into from Apr 20, 2024
Merged

Address remaining typos and issues with new tags #3720

merged 3 commits into from Apr 20, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

  • Fix backwards compat for c:strings

@TelepathicGrunt
Copy link
Contributor Author

Holding onto this for a few days to see if any other issues come up that can be wrapped into this PR

modmuss50
modmuss50 reviewed Apr 19, 2024
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
@TelepathicGrunt
Revert "bump version"
8889239 
This reverts commit 0426403.
modmuss50
modmuss50 approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope you dont mind but im going to undraft this and merge with some other bug fixes now. I dont see a reason to wait 👍

@modmuss50 modmuss50 marked this pull request as ready for review April 20, 2024 10:25
@modmuss50 modmuss50 added bug Something isn't working merge me please Pull requests that are ready to merge small change labels Apr 20, 2024
@modmuss50 modmuss50 merged commit 7ba3e3b into FabricMC:1.20.5 Apr 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge me please Pull requests that are ready to merge small change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TelepathicGrunt @modmuss50