Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

several mods compat #245

Closed
wants to merge 12 commits into from
Closed

several mods compat #245

wants to merge 12 commits into from

Conversation

JieningYu
Copy link

  • ae2(updated one)
  • promenade
  • alloy forgery(creative blaze cake is 96000 because it's deepslate forge's max fueltier.)
  • mores
  • unearthed
  • universal ores
    they all has fabric:load_conditions except alloy forgery fuels because it won't load without alloy forgery.

@JieningYu
several mods compat
42ca92a 
- ae2
- promenade
- alloy_forgery
- mores
- unearthed
- universal ores
from createlpus
@JieningYu
Copy link
Author

I only edited compat data.
A problem occurred configuring root project 'Create'.

Could not resolve all files for configuration ':detachedConfiguration2'.
Could not find org.quiltmc:quilt-mappings:1.18.2+build.21.

@TropheusJ
Copy link
Member

Ignore the build, mavens are funky right now

@JieningYu
Copy link
Author

is create supported quilt?

@TropheusJ
Copy link
Member

We use quilt mappings for docs and params. Latest commit fixed build.

@JieningYu
Copy link
Author

JieningYu commented Apr 15, 2022 •
edited

  • ae2(updated one)
  • promenade
  • alloy forgery(creative blaze cake is 96000 because it's deepslate forge's max fueltier.)
  • mores
  • unearthed
  • universal ores
    they all has fabric:load_conditions except alloy forgery fuels because it won't load without alloy forgery.

now with betternether and immersive weathering support

@JieningYu
Copy link
Author

？

@JieningYu
Copy link
Author

hi?

@AlphaMode
Copy link
Member

your pr is modifying content from the forge version and I don't think it will be accepted unless you reverse it

@JieningYu
Copy link
Author

ok

@JieningYu
Copy link
Author

no modifies now

@JieningYu
Copy link
Author

now with:

  • architects_palette
  • croptopia
  • ecologics
  • techreborn
  • mythicmetals
  • alloygery

@TropheusJ
Copy link
Member

Will try to review this today

@JieningYu JieningYu mentioned this pull request May 5, 2022
Closed
@StockiesLad
Copy link

StockiesLad commented May 5, 2022 •
edited

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight:

Create (crushing) still doesn't process ores from:

modern industrialisation
Mythic metals (idk why????)
Better end (it isn't working?)
Excavated Variants (this uses JSON's so it would be easier)
Industrial revolution
paradise lost
space dimensions (agape space)

Side thing: since this is create plus, electricity compat?

EDIT: thank you JieningYu for your help!

@TropheusJ
Copy link
Member

TropheusJ commented May 5, 2022 •
edited

A lot of these would likely be fixed by tags, which we’re looking into.

@StockiesLad
Copy link

A lot of these would likely be fixed by tags, which we’re looking into.

Fair enough. You guys are doing F*&*ing great! Like there are no word. Just thank you guys for all the work you are putting into this. Getting bugs fixed in literal hours. Fantastic job! Keep it up.

@JieningYu
Copy link
Author

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight:

Create (crushing) still doesn't process ores from:

modern industrialisation

Mythic metals (idk why????)

Better end (it isn't working?)

Excavated Variants (this uses JSON's so it would be easier)

Industrial revolution

paradise lost

space dimensions (agape space)

Side thing: since this is create plus, electricity compat?

EDIT: thank you JieningYu for your help!

This PR is not CreatePlus.
If you want Mythic Metals compat, use the original CreatePlus mod/datapack(datapack dosen't include custom crushed ors feature)

modern industrialisation and paradise lost is planned but agape space and Industrial revolution not
Will support mods that requires bclib when quilted fabric api is out of beta.

@StockiesLad
Copy link

StockiesLad commented May 6, 2022 •
edited

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight:
Create (crushing) still doesn't process ores from:
modern industrialisation
Mythic metals (idk why????)
Better end (it isn't working?)
Excavated Variants (this uses JSON's so it would be easier)
Industrial revolution
paradise lost
space dimensions (agape space)
Side thing: since this is create plus, electricity compat?
EDIT: thank you JieningYu for your help!

This PR is not CreatePlus. If you want Mythic Metals compat, use the original CreatePlus mod/datapack(datapack dosen't include custom crushed ors feature)

modern industrialisation and paradise lost is planned but agape space and Industrial revolution not Will support mods that requires bclib when quilted fabric api is out of beta.

One question, why support quilt when supporting fabric is supporting 2 loaders simultaneously
EDIT: and btw Thank you for the input!

@JieningYu
Copy link
Author

Ok to be clear im not asking u to do any of these, this is just for everybody to get some insight:
Create (crushing) still doesn't process ores from:
modern industrialisation
Mythic metals (idk why????)
Better end (it isn't working?)
Excavated Variants (this uses JSON's so it would be easier)
Industrial revolution
paradise lost
space dimensions (agape space)
Side thing: since this is create plus, electricity compat?
EDIT: thank you JieningYu for your help!

This PR is not CreatePlus. If you want Mythic Metals compat, use the original CreatePlus mod/datapack(datapack dosen't include custom crushed ors feature)
modern industrialisation and paradise lost is planned but agape space and Industrial revolution not Will support mods that requires bclib when quilted fabric api is out of beta.

One question, why support quilt when supporting fabric is supporting 2 loaders simultaneously EDIT: and btw Thank you for the input!

to allure more players to use Quilt

@StockiesLad
Copy link

StockiesLad commented May 6, 2022 •
edited

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now).
Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

@JieningYu
Copy link
Author

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

@StockiesLad
Copy link

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

and disproportionately more bugs.

@maximumpower55
Copy link

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

and disproportionately more bugs.

Its still in beta :/

@StockiesLad
Copy link

Quilt is essentially just another fork of fabric that really doesn't have more then fabric (as of now). Switching modloaders is a mere inconvenience, there is nothing special about quilt aside from it being just another modloader...

Quilt has QSL and more features compared with Fabric.

and disproportionately more bugs.

Its still in beta :/

Indeed! Time will tell how effective quilt is.

@JieningYu
Copy link
Author

i give up this pr.
check createplus if you want better compat.

@JieningYu JieningYu closed this May 13, 2022
@StockiesLad
Copy link

I'm gonna wait for the tag fix by them.

@StockiesLad
Copy link

Bc quilt is too glitchy to use
just crashing all the time

@StockiesLad
Copy link

LambdAuora I'm just waiting for u to dislike this too lmao.

@JieningYu
Copy link
Author

Bc quilt is too glitchy to use just crashing all the time

a create+ datapack for fabric exists

@JieningYu
Copy link
Author

https://github.com/JieningYu/CreatePlus/archive/refs/heads/datapack/fabric/1.18.2.zip

@StockiesLad
Copy link

Thank you for the direct link!

@JieningYu
Copy link
Author

unarchive zhe zip before using

@maximumpower55
Copy link

Bc quilt is too glitchy to use just crashing all the time

Instead of Whining about it, how about you actually report the crash :/

@StockiesLad
Copy link

unarchive zhe zip before using

👍

@StockiesLad
Copy link

Bc quilt is too glitchy to use just crashing all the time

Instead of Whining about it, how about you actually report the crash :/

Nah, how about I don't.

@Fabricators-of-Create Fabricators-of-Create locked as off-topic and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JieningYu @TropheusJ @AlphaMode @StockiesLad @maximumpower55