Remove fake player api in favor of fabrics

README.md

@@ -26,7 +26,6 @@ The latest patch can be found from GitHub Actions as the build number.
 | `data`                   | Additional data generation providers                                                  |
 | `entity`                 | Multipart entities, extra spawn data, removal listening                               |
 | `extensions`             | Extensions to vanilla classes for additional functionality                            |
-| `fake_players`           | A basic fake server player implementation that can be used to simulate player actions |
 | `gametest`               | Tools to make GameTest creation as easy as possible                                   |
 | `lazy_registration`      | A implementation of forge's DeferredRegister system rewritten for fabric              |
 | `loot`                   | A small library to modify mob loot                                                    |

base/build.gradle

@@ -1,6 +1,5 @@
 moduleDependencies(project, [
 		"lazy_registration",
-		"fake_players",
 		"extensions",
 		"transfer",
 		"utility",

base/src/main/java/io/github/fabricators_of_create/porting_lib/mixin/common/PlayerAdvancementsMixin.java

@@ -1,30 +1,21 @@
 package io.github.fabricators_of_create.porting_lib.mixin.common;
 
-import io.github.fabricators_of_create.porting_lib.event.common.AdvancementCallback;
-import net.minecraft.advancements.Advancement;
-import net.minecraft.server.PlayerAdvancements;
-
-import net.minecraft.server.level.ServerPlayer;
-
-import io.github.fabricators_of_create.porting_lib.fake_players.FakePlayer;
-
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.Shadow;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
 
+import io.github.fabricators_of_create.porting_lib.event.common.AdvancementCallback;
+import net.minecraft.advancements.Advancement;
+import net.minecraft.server.PlayerAdvancements;
+import net.minecraft.server.level.ServerPlayer;
+
 @Mixin(PlayerAdvancements.class)
 public abstract class PlayerAdvancementsMixin {
 	@Shadow
 	private ServerPlayer player;
 
-	@Inject(method = "award", at = @At("HEAD"), cancellable = true)
-	private void noAdvancementsForFakePlayers(Advancement advancement, String criterionKey, CallbackInfoReturnable<Boolean> cir) {
-		if (player instanceof FakePlayer)
-			cir.setReturnValue(false);
-	}
-
 	@Inject(method = "award", at = @At(value = "INVOKE", target = "Lnet/minecraft/advancements/AdvancementRewards;grant(Lnet/minecraft/server/level/ServerPlayer;)V"))
 	public void port_lib$onAwardAdvancement(Advancement advancement, String criterionKey, CallbackInfoReturnable<Boolean> cir) {
 		AdvancementCallback.EVENT.invoker().onAdvancement(this.player, advancement);

base/src/main/resources/porting_lib_base.mixins.json

@@ -60,6 +60,7 @@
     "common.NaturalSpawnerMixin",
     "common.PackRepositoryMixin",
     "common.PiglinAiMixin",
+    "common.PlayerAdvancementsMixin",
     "common.PlayerListMixin",
     "common.PlayerMixin",
     "common.PowderSnowBlockMixin",