Skip to content

Commit

Permalink
Fixing issue with slider element in repet group. Refectored slider
Browse files Browse the repository at this point in the history
creation in to makeSlider(), added cloned() method to delete cloned
object and make new one.
  • Loading branch information
cheesegrits committed Sep 10, 2014
1 parent 37a0b27 commit a458893
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion plugins/fabrik_element/slider/slider-min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 16 additions & 5 deletions plugins/fabrik_element/slider/slider.js
Expand Up @@ -10,6 +10,10 @@ var FbSlider = new Class({
initialize: function (element, options) {
this.parent(element, options);
this.plugin = 'slider';
this.makeSlider();
},

makeSlider: function () {
var isNull = false;
if (typeOf(this.options.value) === 'null' || this.options.value === '') {
this.options.value = '';
Expand All @@ -24,10 +28,10 @@ var FbSlider = new Class({
}
this.output = this.element.getElement('.fabrikinput');
this.output2 = this.element.getElement('.slider_output');

this.output.value = this.options.value;
this.output2.set('text', this.options.value);

this.mySlide = new Slider(
this.element.getElement('.fabrikslider-line'),
this.element.getElement('.knob'),
Expand All @@ -47,7 +51,7 @@ var FbSlider = new Class({
steps : this.options.steps
}
).set(v);

if (isNull) {
this.output.value = '';
this.output2.set('text', '');
Expand All @@ -56,7 +60,7 @@ var FbSlider = new Class({
this.watchClear();
}
},

watchClear: function () {
this.element.addEvent('click:relay(.clearslider)', function (e, target) {
e.preventDefault();
Expand Down Expand Up @@ -84,5 +88,12 @@ var FbSlider = new Class({
if (action === 'change') {
this.changejs = js;
}
},

cloned: function (c) {
delete this.mySlide;
this.makeSlider();
this.parent(c);
}
});

});

0 comments on commit a458893

Please sign in to comment.